feat: add longest alternating subsequence #624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czgdp1807
requested changes
Mar 11, 2025
| decreasing = increasing + 1 | ||
|
|
||
| # Return the maximum length | ||
| return max(increasing, decreasing) |
There was a problem hiding this comment.
Would be better to return the increasing sequence as well and not just the length.
…hub.com/FamALouiz/pydatastructs into feature/Longest-Alternating-Subsequence
|
@czgdp1807 Could you please review this? Changes have been made. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References to issue
Resolves #317
Brief description of what was implemented
Comments
The algorithm works in O(n) using a dp + greedy solution. It does not return the actualy subsequence; instead, it returns only the length.